Test distro and mock dnf json cleanup #159
Conversation
When a package's checksum is invalid, include the name and digest in the error message for easier troubleshooting.
The dnfjson_mock package isn't used by the images project and was left over from osbuild-composer. The "test-distro-2" test distribution that was calling it was never used in the images tests. The mock-dnf-json cmd is also duplicated in osbuild-composer and is used there by api tests.
Update the golangci-lint binary in the github action to use the latest version.
The check is very sensitive and returns only false positives: content hashes and test strings.
Fix all instances of gosec G601: Implicit memory aliasing in for loop.
achilleas-k
force-pushed
the
test-cleanup
branch
from
0393a49
to
8edf16f
Compare
|
Should we keep this PR open until osbuild/osbuild-composer#3683 gets worked out in case we need to bring some changes here? |
|
This just needs one commit from this draft (I can never seem to make adding a commit to an existing PR work) - 5325bf5 to switch newTestDistro to a public function. I've updated my PR osbuild/osbuild-composer#3683 to use this, and to fix the cloudapi test failures I was seeing. That PR will of course fail until a new images is vendored, I can do that once this PR is merged. |
Cherry picked and pushed. Thanks! |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
The GitLab CI test generator failed (looks like a flake). Adding back on the queue. |
The dnfjson_mock package isn't used by the images project and was left over from osbuild-composer. The "test-distro-2" test distribution that was calling it was never used in the images tests. The mock-dnf-json cmd is also duplicated in osbuild-composer and is used there by API tests.
The PR also includes a very small functional change: It adds the package name and digest to the error message when the digest/checksum fails to validate.
CI changes: I updated the version of golangci-lint that we use in the GitHub actions and disabled gosec G101 (hardcoded credentials) because it produces too many (and exclusively) false positives. The updated linter revealed a lot of instances of G601 (implicit memory aliasing in for loop) when I ran it locally and I fixed all of them.