bib: make build the default subcommand #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
remove-entrypoint
branch
from
822b0f2
to
1ccaf8b
Compare
mvo5
reviewed
Aug 16, 2024
mvo5
previously approved these changes
Aug 19, 2024
mvo5
force-pushed
the
remove-entrypoint
branch
from
1ccaf8b
to
ac382a2
Compare
achilleas-k
requested changes
Aug 19, 2024
Prior this commit, the bootc-image-builder container image had
a custom entrypoint that hardcoded the use of the build subcommand. This
meant that if a user wanted to use a different subcommand, they had to
overwrite the entrypoint.
This commit changes the cobra code in bib to fallback to build if no
subcommand was given. This is slighly ugly, but it allows us to remove
the custom entrypoint, streamlining the use of subcommands. Let's see
an example of calling the version subcommand:
Before:
podman run --rm -it --entrypoint=/usr/bin/bootc-image-builder \
quay.io/centos-bootc/bootc-image-builder:latest version
After:
sudo podman run --rm -it \
quay.io/centos-bootc/bootc-image-builder:latest version
Kudos to https://github.com/IKukhta for his code from
spf13/cobra#823 (comment)
mvo5
force-pushed
the
remove-entrypoint
branch
from
ac382a2
to
b745747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior this commit, the bootc-image-builder container image had
a custom entrypoint that hardcoded the use of the build subcommand. This
meant that if a user wanted to use a different subcommand, they had to
overwrite the entrypoint.
This commit changes the cobra code in bib to fallback to build if no
subcommand was given. This is slighly ugly, but it allows us to remove
the custom entrypoint, streamlining the use of subcommands. Let's see
an example of calling the version subcommand:
Before:
podman run --rm -it --entrypoint=/usr/bin/bootc-image-builder
quay.io/centos-bootc/bootc-image-builder:latest version
After:
sudo podman run --rm -it
quay.io/centos-bootc/bootc-image-builder:latest version
Kudos to https://github.com/IKukhta for his code from
spf13/cobra#823 (comment)