-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iso: be able to build the ISO #58
Conversation
89bf8d2
to
1c0395e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice! Two things that I would like to see in this PR:
- document this in
README.md
- add the new type to the
--type
description in the argument parser
Wait, will bootupd solve this also for this ISO? I don't expect bootupd to be used there.
I just mean used as far as image construction. Agree it doesn’t make too much sense to have a concept of updating the bootloader of an ISO.
Basically I’m just saying we fixed this papercut for containers and hence when we use containers for the ISO we get this fixed for free.
|
ffe5624
to
4a9d670
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@mvo5 thanks, let's try! |
663541f
to
294743e
Compare
@mvo5 I've backed out the smoke test commit until we resolve the issues with the ISO rebooting and how to handle that in the test case(s). |
This comment was marked as outdated.
This comment was marked as outdated.
866d8cd
to
fb2c787
Compare
Adds another type which will build an ISO with the container embedded for Anaconda to do the rest.
There is no need to have them separate.
`zstd` compression leads to a faster build.
We'll be removing the `ref` from the constructor(s) in `images` at a later point in time as well.
fb2c787
to
502b401
Compare
Needs: osbuild/images#322