Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cross-arch building for iso's #316

Open
cdrage opened this issue Mar 28, 2024 · 3 comments
Open

Allow cross-arch building for iso's #316

cdrage opened this issue Mar 28, 2024 · 3 comments

Comments

@cdrage
Copy link
Contributor

cdrage commented Mar 28, 2024 •
edited
Loading

See issue: containers/podman-desktop-extension-bootc#149

as well as the code below:

bootc-image-builder/bib/cmd/bootc-image-builder/main.go

Line 251 in acb5af5

return nil, fmt.Errorf("cannot build iso for different target arches yet")

I did not see an open issue yet for being able to select different arches for building iso.

At the moment, in order to build .iso, you will have to make sure to not pass in target-arch even if it matches the current architecture.

I didn't see an issue opened up for this issue.
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Mar 28, 2024
@deboer-tim
chore: temporarily ignore arch when building iso
c69fbc4 
Image builder has had an issue for a while now where if you specify the
target arch when building an iso it will fail, even if you're specifying the
current/default arch. We've had enough users hit this (so this extension is
the 'blocking' issue) even though the generated images are also
broken/unusable.

We've discussed possible UI changes (like having a 'no target arch' option,
or allowing no arch to be selected) but we don't really like these and do
not want to make UI changes that could be very temporary - so this is the
simplest workaround for now that will unblock users.

Once the following bug is resolved we will update image builder, remove this
workaround, and if necessary change the UI.

osbuild/bootc-image-builder#316

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Mar 28, 2024
Merged
cdrage pushed a commit to containers/podman-desktop-extension-bootc that referenced this issue Mar 28, 2024
@deboer-tim
chore: temporarily ignore arch when building iso (#246)
07d4b85 
Image builder has had an issue for a while now where if you specify the
target arch when building an iso it will fail, even if you're specifying the
current/default arch. We've had enough users hit this (so this extension is
the 'blocking' issue) even though the generated images are also
broken/unusable.

We've discussed possible UI changes (like having a 'no target arch' option,
or allowing no arch to be selected) but we don't really like these and do
not want to make UI changes that could be very temporary - so this is the
simplest workaround for now that will unblock users.

Once the following bug is resolved we will update image builder, remove this
workaround, and if necessary change the UI.

osbuild/bootc-image-builder#316

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim
Copy link

Even if cross-arch compiling wasn't supported it would be great if the error was omitted when the passed --target-arch matches the current arch (i.e. the same as passing no target).

@ondrejbudai
Copy link
Member

Cross-compiling an ISO is currently out of scope due to technical complexity. However, relaxing the check for the cases when target-arch == current-arch() indeed makes sense. @mvo5 May I ask you to take a look?

@deboer-tim deboer-tim mentioned this issue Apr 4, 2024
Closed
cbr7 pushed a commit to cbr7/podman-desktop-extension-bootc that referenced this issue Apr 11, 2024
@deboer-tim @cbr7
chore: temporarily ignore arch when building iso (containers#246)
fb4794c 
Image builder has had an issue for a while now where if you specify the
target arch when building an iso it will fail, even if you're specifying the
current/default arch. We've had enough users hit this (so this extension is
the 'blocking' issue) even though the generated images are also
broken/unusable.

We've discussed possible UI changes (like having a 'no target arch' option,
or allowing no arch to be selected) but we don't really like these and do
not want to make UI changes that could be very temporary - so this is the
simplest workaround for now that will unblock users.

Once the following bug is resolved we will update image builder, remove this
workaround, and if necessary change the UI.

osbuild/bootc-image-builder#316

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Signed-off-by: Vladimir Lazar <vlazar@redhat.com>
mvo5 added a commit to mvo5/bootc-image-builder that referenced this issue Apr 18, 2024
@mvo5
bib: ignore --target-arch if it is the same as the running arch
39defd7 
If the user passes `--target-arch` and it is the same as the
current arch just ignore the option as this is the default
behavior anyway.

This partly closes
osbuild#316
@mvo5 mvo5 mentioned this issue Apr 18, 2024
Merged
@mvo5
Copy link
Collaborator

mvo5 commented Apr 18, 2024

Cross-compiling an ISO is currently out of scope due to technical complexity. However, relaxing the check for the cases when target-arch == current-arch() indeed makes sense. @mvo5 May I ask you to take a look?

Sorry, I missed this and only saw it now. I opened #364 that should address this.

mvo5 added a commit to mvo5/bootc-image-builder that referenced this issue Apr 18, 2024
@mvo5
bib: ignore --target-arch if it is the same as the running arch
89f2a63 
If the user passes `--target-arch` and it is the same as the
current arch just ignore the option as this is the default
behavior anyway.

This partly closes
osbuild#316
github-merge-queue bot pushed a commit that referenced this issue Apr 18, 2024
@mvo5 @achilleas-k
bib: ignore --target-arch if it is the same as the running arch
28d4f8a 
If the user passes `--target-arch` and it is the same as the
current arch just ignore the option as this is the default
behavior anyway.

This partly closes
#316
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Apr 23, 2024
@deboer-tim
chore: remove bib iso target workaround
4e13d7b 
Bib does not support cross-arch building of ISO images for now:
osbuild/bootc-image-builder#316

However, there was an issue where it would fail if you specify a target arch,
even if that's the current one. This has been fixed and is in the bib that
we currently depend on:
osbuild/bootc-image-builder#364

This removes the workaround we had in place to avoid ISO builds failing.

Fixes containers#269.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim added a commit to deboer-tim/podman-desktop-extension-bootc that referenced this issue Apr 23, 2024
@deboer-tim
chore: remove bib iso target workaround
65292a7 
Bib does not support cross-arch building of ISO images for now:
osbuild/bootc-image-builder#316

However, there was an issue where it would fail if you specify a target arch,
even if that's the current one. This has been fixed and is in the bib that
we currently depend on:
osbuild/bootc-image-builder#364

This removes the workaround we had in place to avoid ISO builds failing.

Fixes containers#269.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Apr 23, 2024
Merged
deboer-tim added a commit to containers/podman-desktop-extension-bootc that referenced this issue Apr 23, 2024
@deboer-tim
chore: remove bib iso target workaround
164a9a7 
Bib does not support cross-arch building of ISO images for now:
osbuild/bootc-image-builder#316

However, there was an issue where it would fail if you specify a target arch,
even if that's the current one. This has been fixed and is in the bib that
we currently depend on:
osbuild/bootc-image-builder#364

This removes the workaround we had in place to avoid ISO builds failing.

Fixes #269.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@cdrage cdrage changed the title Be able to select iso for different arches Allow cross-arch building for iso's May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ondrejbudai @mvo5 @cdrage @deboer-tim