Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest tiny shows misc ASCII characters and escape sequences(?) in lxterminal/alacritty bash/zsh #96

Closed
spease opened this issue Mar 12, 2018 · 12 comments

Comments

@spease
Copy link

spease commented Mar 12, 2018

LXTerminal w/ Alacritty + tmux + zsh (my typical setup)
tiny_alacritty_tmux_zsh

LXTerminal w/ Bash
tiny_lxterminal_bash

LXTerminal w/ ZSH
tiny_lxterminal_zsh

Could very well be a misconfiguration.

@BrianOn99
Copy link
Contributor

Thanks for reporting. This is similar to a issue mentioned in #91 (comment). Could try you export TERM=xterm before running tiny? Please also tell us what OS you are running.

@spease
Copy link
Author

spease commented Mar 12, 2018

I'm running Arch Linux but my zshrc is pretty custom. TERM is set to xterm-256color, IIRC for vim plugins to know that the terminal has that level of support. It's been long enough since I researched this that I've forgotten most of it, but a cursory search today suggests that it's still the right setting to suggest that the terminal supports the maximum level of color support:
https://stackoverflow.com/questions/10003136/what-is-the-difference-between-xterm-color-xterm-256color

Thanks

@osa1
Copy link
Owner

osa1 commented Mar 12, 2018

I think this is also the termbox issue discussed in #91 (comment). @spease could you try running termbox demos from upstream and let us know if they also fail to render properly? I think we should open an issue on termbox github repo.

@BrianOn99
Copy link
Contributor

In case someone want to look into the issue, please run docker image base/devel:2018.02.01 and run upstream termbox demo. It should be fine. Then upgrading from ncurses 6.0+20170902-3 to ncurses 6.1-3 the demo output will be a mess.

@osa1
Copy link
Owner

osa1 commented Mar 12, 2018

It seems like this bug was reported to termbox-go (nsf/termbox-go#185) and fixed with nsf/termbox-go@0847623 . We should port the fix to the C version. Should be fairly simple. Would anyone want to give it a try?

@spease
Copy link
Author

spease commented Mar 20, 2018

I've been meaning to get to testing this, but haven't had the time to figure out what I need to do. Do you still want me to try testing it? If so, what are the exact commands I need to run and what should I look for? Thanks.

@osa1
Copy link
Owner

osa1 commented Mar 20, 2018

No need for testing now, we already figured it out and the bug is fixed in the upstream. We just need to cherry-pick the patch to our fork of termbox. I'll do it this weekend probably (unless someone else does it in the meantime).

@spease
Copy link
Author

spease commented Mar 20, 2018

Thanks, great to hear. I believe I've been using the alacritty-git package in the aur - let me know when the fix should be available (just update the ticket) and I'll give you a confirmation if you'd like.

@spease
Copy link
Author

spease commented Mar 20, 2018

Actually come to think of it, I cargo installed tiny instead of using the git package when troubleshooting. So I should be set up already to pull from am arbitrary source branch

@osa1 osa1 closed this as completed in 5b81389 Mar 24, 2018
@osa1
Copy link
Owner

osa1 commented Mar 24, 2018

This should be fixed now. @BrianOn99 @spease could you try again with the latest version (0.4.1 or just install from git repo) ?

@BrianOn99
Copy link
Contributor

It's OK.

@spease
Copy link
Author

spease commented Apr 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants