Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches: Latest 10/03/2023 #6614

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Conversation

JediKev
Copy link
Contributor

@JediKev JediKev commented Oct 4, 2023

This is a pull containing recent small patches we've aggregated since last release. This includes the following:

  • Adding code to store a Saved Search count on creation.
  • Addresses an issue where sometimes attachments can sometimes not be set in the $data array.
  • Addresses an issue where sometimes the returned $data from the parser can be a type other than an array.
  • Addresses an issue where sometimes an Agent will add Search criteria with !includes but don't add a value.
  • Adds code to append the offending mail headers when an Email Loop is detected.
  • Adds the concept of Retry Codes so we can attempt to reconnect to MySQL in the event of certain error codes (2006 and 1213).
  • Adds a small patch that increases the Auto Add Members From input max length from 60 to 256 to allow more domains.
  • Fixes an issue where sometimes the holidays for schedules can be empty.

This adds code to store a Saved Search count on creation.
This addresses an issue where sometimes attachments can sometimes not be
set in the `$data` array. This adds a check to ensure attachments key
isset in the `$data` array before attempting to use it.
This addresses an issue where sometimes the returned `$data` from the
parser can be a type other than an array. We expect the data to be an
array so to avoid issues/errors this adds a check to ensure `$data` is
an array before we use it.
This addresses an issue where sometimes an Agent will add Search
criteria with `!includes` but don't add a value. This adds a check to
make sure there is a value before attempting the search. If there is no
value we simply return without executing the search to avoid errors.
This adds code to append the offending mail headers when an Email Loop
is detected. This will provide more information on what email exactly is
causing the loop.
This adds the concept of Retry Codes so we can attempt to reconnect to
MySQL in the event of certain error codes (2006 and 1213).
2006 - MySQL server has gone away
1213 - Deadlock found when trying to get lock; try restarting
transaction
This is a small patch that increases the Auto Add Members From input max
length from 60 to 256 to allow more domains.
This fixes an issue where sometimes the holidays for schedules can be
empty. This adds checks to see if holidays is empty/not set in the POST
and if so we try to get the Schedule's existing Holidays and if they
don't exist we default to an empty array. This also adds a further check
to see if `$holidays` is set if not then we default to an empty array.
@protich protich self-requested a review October 11, 2023 19:14
@protich protich merged commit 1a33263 into osTicket:1.17.x Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants