This repository was archived by the owner on Aug 14, 2023. It is now read-only.
Hotfix/cookie message #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cableman
previously requested changes
Aug 11, 2020
| <?php print $doctype; ?> | ||
| <html lang="<?php print $language->language; ?>" dir="<?php print $language->dir; ?>"<?php print $rdf->version . $rdf->namespaces; ?>> | ||
| <head<?php print $rdf->profile; ?>> | ||
| <script id="CookieConsent" src="https://policy.app.cookieinformation.com/uc.js" data-culture="DA" type="text/javascript"></script> |
There was a problem hiding this comment.
Should this JS not have been added in itk_siteimprove_init() hook (which is activated on every page call) with add_js or in an hook_preprocess in itk_siteimprove so it is contained in the module.
This is an hidden dependency.
There was a problem hiding this comment.
https://policy.app.cookieinformation.com/uc.js is not related in any way to siteimprove. It just adds cookie consent banner
martinyde
dismissed
cableman’s stale review
https://policy.app.cookieinformation.com/uc.js is not related in any way to siteimprove and so there is no dependency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cookie message