Skip to content

Conversation

@junland
Copy link
Contributor

@junland junland commented Jul 22, 2015

Did some clean up and added a list all applications / pkgs. Still need to work out a API but were getting there.

John Unland added 6 commits July 22, 2015 09:55
This page will list all available packages.
Clean up code.
Cleaned up code.
Added ability to read packages.json data and output into a table. (Not tested yet.)
Added view all applications / packages to the navbar.
Added link to list all packages / applications.
andersevenrud added a commit that referenced this pull request Jul 22, 2015
Added listpgks.html and did some cleaning up.
@andersevenrud andersevenrud merged commit 3b2c0f0 into os-js:master Jul 22, 2015
@andersevenrud
Copy link
Member

Cool. I'll clone this locally and have a look :)

@junland
Copy link
Contributor Author

junland commented Jul 22, 2015

Thanks, could you look at allpkgs.html. Having trouble getting json to display on the table.

@andersevenrud
Copy link
Member

Just comitted 1fd07c1. Fixes table rendering.

Getting this error in console:

Uncaught SyntaxError: Unexpected token (materialize.min.js:910)

Seems weird.

@junland
Copy link
Contributor Author

junland commented Jul 22, 2015

@andersevenrud Thanks.

Getting this error in console:
Uncaught SyntaxError: Unexpected token (materialize.min.js:910)
Seems weird.

Getting that too. 910 is pointing to line 910 in that js file. I'll go file a issue with the Materialize Project.

@andersevenrud
Copy link
Member

First check if there is a newer version available :)

@junland
Copy link
Contributor Author

junland commented Jul 22, 2015

Will do :)

@junland
Copy link
Contributor Author

junland commented Jul 22, 2015

Yea 0.97 is the current, and that's what were running right now. I haven't made any changes to the source files except the color of the navbar in the CSS file

You can view the issue here: Dogfalo/materialize#1776

@junland junland changed the title Added listpgks.html and did some cleaning up. Added listpkgs.html and did some cleaning up. Jul 22, 2015
@andersevenrud
Copy link
Member

Did you build this materialize lib yourself ? Or was it just a prebuilt download ?
Also was the changes to javascript ? If so, you might have broken something there.

@junland
Copy link
Contributor Author

junland commented Jul 22, 2015

It was a prebuilt download. Maybe I did something wrong in the tags?

<head>
<!--Import materialize.css-->
<link type="text/css" rel="stylesheet" href="css/materialize.min.css" media="screen,projection" />

<!--Let browser know website is optimized for mobile-->
<meta name="viewport" content="width=device-width, initial-scale=1.0" />

<!--Import jQuery before materialize.js-->
<script type="text/javascript" src="https://code.jquery.com/jquery-2.1.1.min.js"></script>
<script type="text/javascript" src="js/materialize.min.js"></script>
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
</head>

@andersevenrud
Copy link
Member

It's a syntax error, so it's a problem in the build. I added a patch in the issue you made.

@junland
Copy link
Contributor Author

junland commented Jul 22, 2015

Yeaaaaa, It's such a small syntax error that no wonder I assumed it was on there end. Lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants