Skip to content

Revert recent changes regarding osc invocations #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Martchus wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Revert recent changes regarding osc invocations #520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6202144
Revert "fix: Log information about retrying introduced in 42165e49 to…
Martchus Feb 6, 2026
feed459
Revert "feat: Avoid processing invalid `osc` output"
Martchus Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions _common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,19 +417,5 @@ log-error() (
debug_osc() (
set +x
log-debug "### osc $*"
local out attempts=${osc_output_retries:-3} sleep_interval=${osc_sleep_interval:-3}
out=$($osc "$@")
while [[ $attempts -gt 0 ]] && [[ $out =~ ((Request|Headers|date|server):) ]]; do
attempts=$((attempts - 1))
log-warn "'$osc $*' output seems to contain HTTP header."
if [[ $attempts -eq 0 ]]; then
log-warn "Full output: $out"
return 1
fi
log-warn "Trying $attempts more times after $sleep_interval seconds …"
sleep "$sleep_interval"
sleep_interval=$((sleep_interval * 2))
out=$($osc "$@")
done
echo -n "$out"
$osc "$@"
)