Introduce python style checks with ruff #395
Conversation
okurz
force-pushed
the
feature/python_style
branch
from
95b3d13 to
f3d986d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
okurz
force-pushed
the
feature/python_style
branch
from
f3d986d to
92e7c02
Compare
okurz
force-pushed
the
feature/python_style
branch
8 times, most recently
from
8eec72a to
44256ed
Compare
This uses a custom CI image also providing ruff.
okurz
force-pushed
the
feature/python_style
branch
from
44256ed to
e9615e8
Compare
|
All problems fixed now. |
| join(self.url, "index.php"), | ||
| params=params | ||
| ) | ||
| params = "&".join("%s=%s" % (k, v) for k, v in search_payload.items()) |
There was a problem hiding this comment.
Why do you need this with requests? I am pretty sure passing the search_payload in the params should work out
There was a problem hiding this comment.
Please only comment on the changes made in this PR which is only adjusting the style with ruff. I didn't even read the changed code in detail.
| elif status >= 300: | ||
| raise Exception(f"Racktables returned statuscode {status} while trying to access {req.request.url}. Manual investigation needed.") | ||
| raise Exception( | ||
| f"Racktables returned statuscode {status} while trying to access {req.request.url}. Manual investigation needed." |
There was a problem hiding this comment.
just for clarity. it meant to be statuscode or status code?
| try: | ||
| print(obj.fqdn, flush=True) | ||
| except: | ||
| except Exception: | ||
| print(obj.common_name, flush=True) |
There was a problem hiding this comment.
what Exception is expected here? likely that obj is not defined or something. but it looks to me that the try should enclose the
url_path = result_obj.find("a")["href"]
obj = RacktablesObject(rt)
obj.from_path(url_path)
and not the print. wdyt?
| import json | ||
| import os.path | ||
| import sys | ||
| import re |
There was a problem hiding this comment.
this is not related to the style I guess. Maybe a separate commit?
There was a problem hiding this comment.
It is related to style changes by removing unused changes. I only applied changes suggested by ruff
There was a problem hiding this comment.
Technically @b10n1k is correct. This is not a style change. I assume ruff is not just about coding style and complains about all sorts of "problems".
|
This is not available in leap 15.6, which is unfortunate, since it breaks OBS checks right now. |
4 participants
No description provided.