Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfstests/partition.pm: add section name when configuring nfsmount.conf file #20588

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Avinesh
Copy link
Contributor

@Avinesh Avinesh commented Nov 8, 2024

several xfstests in o3/xfstests_nfs3-generic has been failing with

+mount.nfs: config error at /etc/nfsmount.conf:1: ignoring line not in a section 
+mount.nfs: config error at /etc/nfsmount.conf:2: ignoring line not in a section 

so, adding the section name in nfsmount config file

several xfstests in o3/xfstests_nfs3-generic fails with
config error at /etc/nfsmount.conf:1: ignoring line not in a section
so, adding the section name in nfsmount config file

Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
Copy link
Contributor

@pevik pevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I vote to merge now. From your VR it looks it does not need to handle /etc/nfsmount.conf and /usr/etc/nfsmount.conf (if yes, we can do it as a separate effort).

@Avinesh
Copy link
Contributor Author

Avinesh commented Nov 11, 2024

LGTM. I vote to merge now. From your VR it looks it does not need to handle /etc/nfsmount.conf and /usr/etc/nfsmount.conf (if yes, we can do it as a separate effort).

@pevik , Thanks for the review. Yes, for this particular failure issue this is sufficient. We can address /etc/ and /usr/etc thing separately.

@pevik pevik merged commit 9087587 into os-autoinst:master Nov 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants