Remove deprecated die_on_timeout #19904
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
What you put into the description of the pull request could also be in the commit message details. I don't know how you created your pull request but your git commit messages has only the subject line while the pull request description has more details. Please keep in mind that the github pull request description is only visible on github, the commit can be considered permanent information storage.
I can recommend the tool hub (zypper in rubygem-hub) for easier PR creation. Also, I myself use a script git-pr-last to create a PR with proper description for these simple one-commit PRs:
$ cat $(which git-pr-last )
#!/bin/sh -e
target="${target:-"$USER"}"
git push $target && git show --no-patch --format=%B | hub pull-request -F -You might want to use the more up-to-date tool https://github.com/cli/cli
See https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/CONTRIBUTING.md#coding-style for more details
The call script_run(..., die_on_timeout => 0) is deprecated and soon to be removed from os-autoinst. This commit replaces the trento lib call by simply removing "die_on_timeout => 0" as not actually needed or not necessary anymore after underlying bugs are fixed. Related progress issue: https://progress.opensuse.org/issues/164712
mpagot
force-pushed
the
trento_deprecated_die_on_timeout
branch
from
24f17f1 to
6d69db2
Compare
The call script_run(..., die_on_timeout => 0) is deprecated and soon to
be removed from os-autoinst.
This commit replaces the trento lib call by simply removing "die_on_timeout => 0"
as not actually needed or not necessary anymore after underlying bugs are fixed.
Related progress issue: https://progress.opensuse.org/issues/164712