-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for latest deployment release #19490
Add support for latest deployment release #19490
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe add a unit test in t/09_qesapdeployment.t
6f57fc6
to
3447e33
Compare
e9ac029
to
6987974
Compare
lib/qesapdeployment.pm
Outdated
if (get_var('QESAP_INSTALL_VERSION') eq 'latest') { | ||
my $latest_release_url = "https://$official_repo/releases/latest"; | ||
my $redirect_url = script_output("curl -s -L -o /dev/null -w %{url_effective} $latest_release_url"); | ||
if ($redirect_url =~ /\/tag\/v([0-9.]+)$/) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
die "Failed to parse the latest version from $redirect_url" if ($redirect_url !~ /\/tag\/v([0-9.]+)$/);
my $version = $1;
$ver_artifact = "v$version.tar.gz";
record_info("Latest QE-SAP-DEPLOYMENT release used: $version", $version);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6987974
to
6523d57
Compare
6523d57
to
0b4ba00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds support for the keyword
latest
inQESAP_INSTALL_VERSION
, along with explicit version number.It uses the github api to fetch the latest release tag, and downloads it.
USING LATEST KEYWORD: https://openqaworker15.qa.suse.cz/tests/285990#step/configure/83