Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention NO_REMINDER_REGEX as additional option to prevent reminders #222

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

okurz
Copy link
Member

@okurz okurz commented Aug 1, 2024

openqa_review/openqa_review.py Outdated Show resolved Hide resolved
@perlpunk
Copy link
Contributor

perlpunk commented Aug 2, 2024

huh.
https://github.com/os-autoinst/openqa_review/actions/runs/10213705644/job/28259653606?pr=222#step:7:87

E           AttributeError: 'NoneType' object has no attribute 'pattern'

ah. there is a test doing args.ignore_pattern = None. maybe not a useful thing to do, as the script makes sure it always has a default. Not sure if it's even possible to set it to None via a command line option.

@okurz
Copy link
Member Author

okurz commented Aug 2, 2024

huh. https://github.com/os-autoinst/openqa_review/actions/runs/10213705644/job/28259653606?pr=222#step:7:87

E           AttributeError: 'NoneType' object has no attribute 'pattern'

ah. there is a test doing args.ignore_pattern = None. maybe not a useful thing to do, as the script makes sure it always has a default. Not sure if it's even possible to set it to None via a command line option.

True. I changed it in the test to args.ignore_pattern = re.compile("THIS_WILL_NOT_MATCH")

@mergify mergify bot merged commit 166a7b1 into os-autoinst:master Aug 2, 2024
9 checks passed
@okurz okurz deleted the feature/reopen branch August 4, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants