Skip to content

Remove stuck CI checks with Python 3.6 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove stuck CI checks with Python 3.6 #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
include:
- os: "ubuntu-latest"
- os: "ubuntu-20.04"
python-version: "3.6"
Copy link

@d3flex d3flex Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore this and the CI will work. I tested here #68. I used 3.11 because I think this is the latest in Ubuntu, but you just need one. I will close my PR now

Copy link
Contributor Author

@Martchus Martchus Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll try tomorrow.

Copy link
Contributor Author

@Martchus Martchus Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see whether just bumping this version works - but probably not and we'll still have to remove Python 3.6.

Copy link
Member

@okurz okurz Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this change looks weird. Why try to use "ubuntu-latest" for all versions including 3.6 but use the old 20.04 for 3.11? Maybe you wanted to remove 3.6 completely in line 14 but as Adam and me suggested to keep it have you tried to use a different base than 20.04 for 3.6?

python-version: "3.11"

steps:
- uses: actions/checkout@v4
Expand Down
Loading