Improve parsing #36
Merged
Improve parsing #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `any' and `not-newline' are converted to the "." regular expression. I find the later more explicit and this use of `any' isn't mentioned in the docstring of `rx' (in Emacs 29.2 at least).
In some cases, eslint can produce a multi-line error message. This happens for example for the import/no-deprecated rule [1] which shows a user-constructed message in the error. Replacing `any' (which matches anything but a new line) with `anychar' allows for matching new lines within the message. [1] https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-deprecated.md
Even if "--format json" is passed to eslint, the output will be non-json in case of a crash, e.g., Error: Failed to load plugin 'foo' declared in '.eslintrc.cjs': Cannot find module 'eslint-plugin-foo' … This commit makes sure that such eslint's crash doesn't prevent flymake-eslint from reporting the error.
|
/cc @orzechowskid Is there any interest in this PR? |
|
apologies for my lack of communication, I don't have much free time these days. this looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of 3 commits: