Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WithSpanFromContext logrus helper #787

Merged
merged 2 commits into from
May 27, 2024

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this May 27, 2024
@jonas-jonas jonas-jonas marked this pull request as ready for review May 27, 2024 13:15
@jonas-jonas jonas-jonas requested a review from zepatrik May 27, 2024 13:15
logrusx/helper.go Outdated Show resolved Hide resolved
logrusx/helper.go Outdated Show resolved Hide resolved
@jonas-jonas jonas-jonas changed the title feat: add WithSpan logrus helper feat: add WithSpanFromContext logrus helper May 27, 2024
@zepatrik zepatrik merged commit b1133d6 into master May 27, 2024
9 checks passed
@zepatrik zepatrik deleted the jonas-jonas/addWithSpanLogrusHelper branch May 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants