Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code strategy should not reset UI messages when populating login flow (PS-557) #4190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

splaunov
Copy link
Contributor

@splaunov splaunov commented Nov 5, 2024

This PR fixes an issue when duplicate credentials error added by OIDC strategy into new login flow is lost because code strategy clears all messages when populating login flow.

This is where OIDC strategy adds duplicate credentials error into flow ui messages list:

if validationErr := new(schema.ValidationError); errors.As(err, &validationErr) {
for _, m := range validationErr.Messages {
m := m
rf.UI.Messages.Add(&m)
}
} else {
rf.UI.Messages.Add(text.NewErrorValidationDuplicateCredentialsOnOIDCLink())
}
lf, err := s.registrationToLogin(ctx, w, r, rf)

Related issue(s)

Checklist

  • [ x] I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • [x ] I am following the
    contributing code guidelines.
  • [ x] I have read the security policy.
  • [ x] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant