feat: add support for client TLS certs #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonsthere
requested changes
Jun 24, 2021
| {{- if .Values.certs.enabled }} | ||
| - name: {{ include "oathkeeper.name" . }}-certs | ||
| secret: | ||
| secretName: {{- if .Values.certs.existingSecret }} |
There was a problem hiding this comment.
Suggested change
| secretName: {{- if .Values.certs.existingSecret }} | |
| secretName: {{- .Values.certs.existingSecret }} |
| @@ -42,16 +42,21 @@ spec: | |||
| - name: {{ include "oathkeeper.name" . }}-config-volume | |||
| configMap: | |||
| {{- if .Values.demo }} | |||
| name: {{ include "oathkeeper.fullname" . }}-config-demo | |||
| name: {{ include "oathkeeper.name" . }}-config-demo | |||
There was a problem hiding this comment.
Please do not change this, and use fullname. This allows installation of multiple instances without resource overlapping.
aeneasr
requested changes
Jul 5, 2021
There was a problem hiding this comment.
I think it would make sense to use the extraVolume pattern we have in Ory Kratos instead: https://github.com/ory/k8s/blob/master/helm/charts/kratos/values.yaml#L167-L179 :)
|
I can work on introducing that pattern |
|
As per ory/oathkeeper#744 (comment) marking this as draft |
|
There's a hard and fast addition of extraVolume's at #330 - I found myself to need it to get TLS certs into the pod :) |
|
I'd say lets deprecate this PR in favour of #330. @christian-roggia are you ok with this? |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
ory/oathkeeper#744