Skip to content
This repository was archived by the owner on May 12, 2025. It is now read-only.

fix: update packages & replace request dependency - #60

Merged
aeneasr merged 9 commits into
ory:mainfrom
t1nky:main
Mar 13, 2024
Merged

fix: update packages & replace request dependency#60
aeneasr merged 9 commits into
ory:mainfrom
t1nky:main

Conversation

@t1nky

@t1nky t1nky commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

Updated dependencies
Removed the usage of request in next-edge
Added support for Next.js App Router
Overall refactor: separate common functions and consts

add app router support
bump deps
fix tests
separate common functions and consts
refactor tests
removed tostring call for url in fetch
build url in next-edge
@CLAassistant

CLAassistant commented Feb 28, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jonas-jonas jonas-jonas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is great.

I fixed the failing type import for you.

@jonas-jonas
jonas-jonas requested a review from aeneasr March 5, 2024 09:23
@jonas-jonas

Copy link
Copy Markdown
Member

@t1nky Ah, just saw, could you sign the CLA? Otherwise, we can't merge this PR.

@jonas-jonas jonas-jonas changed the title App router support + Overall refactor fix: update pacakges & replace request dependency Mar 5, 2024
@jonas-jonas jonas-jonas changed the title fix: update pacakges & replace request dependency fix: update packages & replace request dependency Mar 5, 2024
@t1nky

t1nky commented Mar 13, 2024

Copy link
Copy Markdown
Contributor Author

@t1nky Ah, just saw, could you sign the CLA? Otherwise, we can't merge this PR.

Done, apologize for the delay

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants