Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable datadog tracer #3431

Merged
merged 4 commits into from
Feb 6, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix config format
  • Loading branch information
sawadashota committed Feb 6, 2023
commit 5ee9c753c773b9d8ae5d20ac80b614b0315610ce
5 changes: 1 addition & 4 deletions internal/.hydra.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,8 @@ tracing:
providers:
jaeger:
local_agent_address: 127.0.0.1:6831
propagation: jaeger
max_tag_value_length: 1024
sampling:
type: const
value: 1
trace_id_ratio: 1
server_url: http://sampling
zipkin:
server_url: http://zipkin/api/v2/spans
11 changes: 1 addition & 10 deletions internal/config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -443,21 +443,12 @@ tracing:
jaeger:
# The address of the jaeger-agent where spans should be sent to
local_agent_address: 127.0.0.1:6831
# The tracing header format
propagation: jaeger
# The maximum length of jaeger tag value
max_tag_value_length: 1024
sampling:
# The type of the sampler you want to use. Supports:
# - const
# - probabilistic
# - ratelimiting
type: const
# The value passed to the sampler type that has been configured.
# Supported values: This is dependant on the sampling strategy used:
# - const: 0 or 1 (all or nothing)
# - rateLimiting: a constant rate (e.g. setting this to 3 will sample requests with the rate of 3 traces per second)
# - probabilistic: a value between 0..1
value: 1.0
trace_id_ratio: 1.0
# The address of jaeger-agent's HTTP sampling server
server_url: http://localhost:5778/sampling
3 changes: 1 addition & 2 deletions quickstart-tracing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ services:
### Jaeger ###
- TRACING_PROVIDERS_JAEGER_SAMPLING_SERVER_URL=http://jaeger:5778/sampling
- TRACING_PROVIDERS_JAEGER_LOCAL_AGENT_ADDRESS=jaeger:6831
- TRACING_PROVIDERS_JAEGER_SAMPLING_TYPE=const
- TRACING_PROVIDERS_JAEGER_SAMPLING_VALUE=1
- TRACING_PROVIDERS_JAEGER_SAMPLING_TRACE_ID_RATIO=1
### Zipkin ###
# - TRACING_PROVIDERS_ZIPKIN_SERVER_URL=http://zipkin:9411/api/v2/spans
### DataDog ###
Expand Down