Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent multiple redirections to post logout url #3366

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fix: prevent multiple redirections to post logout url #3366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2e033
fix: remove all timeouts when the redirection worked
CGNonofr Nov 16, 2022
e6cbbe4
fix: fix misleading comments
CGNonofr Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions oauth2/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,23 +141,40 @@ func (h *Handler) performOidcFrontOrBackChannelLogout(w http.ResponseWriter, r *
var total = {{ len .FrontChannelLogoutURLs }};
var redir = {{ .RedirectTo }};

var timeouts = [];
var redirected = false;
// Cancel all pending timeouts to avoid to call the frontchannel multiple times.
window.onbeforeunload = () => {
redirected = true;
for (var i=0; i<timeouts.length; i++) {
clearTimeout(timeouts[i]);
}
timeouts = [];
};
function setAndRegisterTimeout(fct, duration) {
if (redirected) {
return;
}
timeouts.push(setTimeout(fct, duration));
}

function redirect() {
window.location.replace(redir);

// In case replace failed try href
setTimeout(function () {
setAndRegisterTimeout(function () {
window.location.href = redir;
}, 250); // Show message after http-equiv="refresh"
}, 250);
}

function done() {
total--;
if (total < 1) {
setTimeout(redirect, 500);
setAndRegisterTimeout(redirect, 500);
}
}

setTimeout(redirect, 7000); // redirect after 5 seconds if e.g. an iframe doesn't load
setAndRegisterTimeout(redirect, 7000); // redirect after 7 seconds if e.g. an iframe doesn't load

// If the redirect takes unusually long, show a message
setTimeout(function () {
Expand Down