Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recommend to start with one container in prod to complete first-time setup. #2945

Merged
merged 1 commit into from
Jan 21, 2022
Merged

docs: recommend to start with one container in prod to complete first-time setup. #2945

merged 1 commit into from
Jan 21, 2022

Conversation

mig5
Copy link
Contributor

@mig5 mig5 commented Jan 20, 2022

Just a PR as per invitation, to reflect the discussion at #2943 (reply in thread)

Thanks!

Checklist

@mig5 mig5 changed the title Docs change: recommend to start with one container in production to complete first-time setup. docs: recommend to start with one container in prod to complete first-time setup. Jan 20, 2022
…-time setup.

This is to ensure multiple concurrent workers don't both generate JWKs needlessly, for example.

See #2943 (reply in thread)
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #2945 (bae2cff) into master (2d54490) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2945      +/-   ##
==========================================
+ Coverage   79.73%   79.76%   +0.02%     
==========================================
  Files         113      113              
  Lines        8054     8054              
==========================================
+ Hits         6422     6424       +2     
+ Misses       1226     1223       -3     
- Partials      406      407       +1     
Impacted Files Coverage Δ
persistence/sql/persister_oauth2.go 80.85% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d54490...bae2cff. Read the comment docs.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@aeneasr aeneasr merged commit e257f3e into ory:master Jan 21, 2022
@vinckr
Copy link
Member

vinckr commented Jan 24, 2022

Hello @mig5
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email to claim your Ory swag!

@mig5 mig5 deleted the docs-prod-one-container-seeding branch January 24, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants