Skip to content

hydra/fosite/authorize_helper.go deviates from ory/fosite/authorize_helpers around 8252 #4104

@jdnurmi

Description

@jdnurmi

Preflight checklist

Ory Network Project

No response

Describe the bug

fosite/authorize_helper.go which appears to be used by hydra directly (rather than importing ory/fosite) has different sermantics around RFC8252 -- in that hydras doesn't recognize "localhost" or "localhost.localdomain" as localhost - meaning the port match becomes required for http://localhost/callback where as for http://127.0.0.1/callback would allow any port.

Reproducing the bug

Add localhost as a callback by name. try calling back on a different port.

Relevant log output

Relevant configuration

Version

v26.2.0

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

For many third party applications we don't control if they refer to themselves as 127.0.0.1 or localhost - being able to support them interchangeably would be helpful

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is not working.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions