Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: scopes_supported doesn't have offline_access #1866

Closed
sawadashota opened this issue May 22, 2020 · 1 comment · Fixed by #1870
Closed

config: scopes_supported doesn't have offline_access #1866

sawadashota opened this issue May 22, 2020 · 1 comment · Fixed by #1870
Labels
bug Something is not working.
Milestone

Comments

@sawadashota
Copy link
Contributor

Describe the bug

Document says supported_scope at discovery always has offline_access but actually discovery doesn't have it.
https://www.ory.sh/hydra/docs/reference/configuration

Reproducing the bug

Steps to reproduce the behavior:

  1. Run DSN=memory go run main.go serve all
  2. Make API Request to with curl -k https://127.0.0.1:4444/.well-known/openid-configuration
  3. Response doesn't have offline_access at scopes_supported property

Expected behavior

I'm not sure which way hydra should go.

  • Response should have offline_access at scopes_supported property
  • Document should be fixed

Environment

  • Version: git sha hash 5661ec3
  • Environment: Mac

Additional context

DefaultClientScope has offline_access

[]string{"offline_access", "offline", "openid"},

but OIDCDiscoverySupportedScope doesn't have

[]string{"offline", "openid"},

@aeneasr
Copy link
Member

aeneasr commented May 23, 2020

Oh, thanks, would you be up for a PR to fix this? :)

@aeneasr aeneasr added the bug Something is not working. label May 23, 2020
@aeneasr aeneasr added this to the v1.5.0 milestone May 23, 2020
aeneasr pushed a commit that referenced this issue May 25, 2020
Closes #1866

Signed-off-by: sawadashota <xiootas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants