fix: cleanup persister

consent/strategy_logout_test.go

@@ -184,7 +184,10 @@ func TestLogoutFlows(t *testing.T) {
 			checkAndAcceptLoginHandler(t, adminApi, subject, func(t *testing.T, res *hydra.OAuth2LoginRequest, err error) hydra.AcceptOAuth2LoginRequest {
 				require.NoError(t, err)
 				//res.Payload.SessionID
-				return hydra.AcceptOAuth2LoginRequest{Remember: pointerx.Ptr(true), IdentityProviderSessionId: pointerx.Ptr(kratos.FakeSessionID)}
+				return hydra.AcceptOAuth2LoginRequest{
+					Remember:                  pointerx.Ptr(true),
+					IdentityProviderSessionId: pointerx.Ptr(kratos.FakeSessionID),
+				}
 			}),
 			checkAndAcceptConsentHandler(t, adminApi, func(t *testing.T, res *hydra.OAuth2ConsentRequest, err error) hydra.AcceptOAuth2ConsentRequest {
 				require.NoError(t, err)

persistence/sql/persister_consent.go

@@ -422,19 +422,13 @@ func (p *Persister) ConfirmLoginSession(ctx context.Context, session *flow.Login
 		return p.CreateWithNetwork(ctx, session)
 	}
 
-	var IdentityProviderSessionID string
-	if session != nil {
-		IdentityProviderSessionID = session.IdentityProviderSessionID.String()
-	}
-
 	// In some unit tests, we still confirm the login session without data from the cookie. We can remove this case
 	// once all tests are fixed.
 	n, err := p.Connection(ctx).Where("id = ? AND nid = ?", id, p.NetworkID(ctx)).UpdateQuery(&flow.LoginSession{
-		AuthenticatedAt:           sqlxx.NullTime(authenticatedAt),
-		Subject:                   subject,
-		Remember:                  remember,
-		IdentityProviderSessionID: sqlxx.NullString(IdentityProviderSessionID),
-	}, "authenticated_at", "subject", "remember", "identity_provider_session_id")
+		AuthenticatedAt: sqlxx.NullTime(authenticatedAt),
+		Subject:         subject,
+		Remember:        remember,
+	}, "authenticated_at", "subject", "remember")
 	if err != nil {
 		return sqlcon.HandleError(err)
 	}