Skip to content

Conversation

@kimnieyh
Copy link

@kimnieyh kimnieyh commented May 12, 2025

Description

Added full Korean (ko) translation JSON and integrated it into OryLocales.

Related Issue

No specific issue reported.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
  • If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@vercel
Copy link

vercel bot commented May 12, 2025

@kimnieyh is attempting to deploy a commit to the ory Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2025

⚠️ No Changeset found

Latest commit: 91b2618

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented May 12, 2025

CLA assistant check
All committers have signed the CLA.

@kimnieyh kimnieyh changed the title feat(locales): add Korean translation feat(core): add Korean translation May 12, 2025
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.00%. Comparing base (f3fad4d) to head (91b2618).
Report is 178 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   42.43%   52.00%   +9.57%     
==========================================
  Files         136      152      +16     
  Lines        2008     2623     +615     
  Branches      288      391     +103     
==========================================
+ Hits          852     1364     +512     
- Misses       1149     1235      +86     
- Partials        7       24      +17     
Components Coverage Δ
@ory/elements-react 49.69% <ø> (+12.90%) ⬆️
@ory/nextjs 62.66% <ø> (-3.32%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Update ko.json

chore: format ko.json
@kimnieyh kimnieyh marked this pull request as draft May 13, 2025 04:22
@kimnieyh kimnieyh marked this pull request as ready for review May 23, 2025 08:17
@kimnieyh kimnieyh marked this pull request as draft July 9, 2025 04:30
@kimnieyh kimnieyh marked this pull request as ready for review July 9, 2025 04:30
@kimnieyh kimnieyh closed this Jul 9, 2025
@kimnieyh
Copy link
Author

kimnieyh commented Jul 9, 2025

Closing this since no feedback was provided for a while,
despite being the earliest translation PR.

Feel free to reopen or reuse any part if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants