fix: Remove extraneous "KLM" characters from beginning of NIE check #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If such characters were present in the NIE to be checked a TypeError would be thrown: TypeError: Unsupported operand types: string % int Tried to find any evidence of these charatcters actually being allowed for Spanish NIE but no evidence of such a thing was found. If this were an error and they are in fact supported then proper handling of those inputs is advised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If such characters were present in the NIE to be checked a TypeError would be thrown:
TypeError: Unsupported operand types: string % int
Tried to find any evidence of these charatcters actually being allowed for Spanish NIE but no evidence of such a thing was found. If this were an error and they are in fact supported then proper handling of those inputs is advised.
Also, haven't found any tests for this, adding to the assumption this isn't intentional.