Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composable): prevent scrolling parent error with parent null #794

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

mlmoravek
Copy link
Member

Fixes #742

Proposed Changes

  • add isDefined check for nextParent in getScrollingParent composable

@mlmoravek mlmoravek added the bug Something isn't working label Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 3451931
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65d5f5d42d69c50008e968f3
😎 Deploy Preview https://deploy-preview-794--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cefffc2) 54.32% compared to head (3451931) 54.32%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #794   +/-   ##
========================================
  Coverage    54.32%   54.32%           
========================================
  Files           31       31           
  Lines         1493     1493           
  Branches       530      531    +1     
========================================
  Hits           811      811           
  Misses         682      682           
Flag Coverage Δ
oruga-next 54.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 34670d4 into oruga-ui:develop Feb 22, 2024
9 checks passed
@mlmoravek mlmoravek deleted the scroll-parent branch February 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getScrollingParent() causes runtime error in custom elements
1 participant