fix(isDefined): remove unintended unref function (#834)

oruga-ui · Mar 4, 2024 · ed75a71 · ed75a71
1 parent f2fc5a6
commit ed75a71
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/oruga/src/composables/defineClasses.ts b/packages/oruga/src/composables/defineClasses.ts
@@ -84,7 +84,9 @@ export function defineClasses(
             scope.run(() => {
                 watch(
                     () => toValue(suffix),
-                    () => {
+                    (value, oldValue) => {
+                        // only recompute when value has really changed
+                        if (value === oldValue) return;
                         // recompute the class bind property
                         const classBind = getClassBind();
                         // update class binding property by class index
@@ -99,7 +101,10 @@ export function defineClasses(
             scope.run(() => {
                 watch(
                     () => toValue(apply),
-                    (applied) => {
+                    (applied, oldValue) => {
+                        // only change apply when value has really changed
+                        if (applied === oldValue) return;
+
                         // get class binding property by class index
                         const classBind = classes.value[index];
 

diff --git a/packages/oruga/src/utils/helpers.ts b/packages/oruga/src/utils/helpers.ts
@@ -1,5 +1,3 @@
-import { unref } from "vue";
-
 /**
  * Generates a random string
  */
@@ -106,8 +104,7 @@ export function indexOf<T>(
 export const isObject = <T>(obj: T): boolean =>
     obj && typeof obj === "object" && !Array.isArray(obj);
 
-export const isDefined = <T>(d: T): boolean =>
-    unref(d) !== null && unref(d) !== undefined;
+export const isDefined = <T>(d: T): boolean => d !== null && d !== undefined;
 
 export function blankIfUndefined(value: string): string {
     return typeof value !== "undefined" && value !== null ? value : "";