Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix serializer bug #52

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix serializer bug #52

merged 1 commit into from
Nov 14, 2023

Conversation

JoE11-y
Copy link
Contributor

@JoE11-y JoE11-y commented Nov 10, 2023

Feature type

  • UI
  • Implementation
  • Specification
  • CI/CD
  • Other

Feature description for issue #51

  • Updated the Schema.js file to properly handle the public-keys serialization.
  • Updated the piglet_bank.ts example to use public-keys.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Your code builds clean without any errors or warnings.
  • Tests for changes have been added (for bug fixes / features). If no, why?

chiro-hiro
chiro-hiro approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@chiro-hiro chiro-hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!.

@chiro-hiro chiro-hiro merged commit b7308cc into main Nov 14, 2023
1 check failed
@chiro-hiro chiro-hiro deleted the fix/serialization-bug branch November 14, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiro-hiro chiro-hiro chiro-hiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoE11-y @chiro-hiro