Feature/zkdb as a service #47
Conversation
| * @returns Promise<boolean> | ||
| */ | ||
| public async isFile(path: string = ''): Promise<boolean> { | ||
| const filepath = `${this.pathBase}/${path}`; |
There was a problem hiding this comment.
String conjugation produces inconsistent results. We should use path.join instead: path.join(this.pathBase, filePath)
There was a problem hiding this comment.
String conjugation produces inconsistent results. We should use path.join instead: path.join(this.pathBase, filePath)
It could be needless for IPFS. At least, I encountered an error suggesting a file didn't exist, even though it does. path.join helped me to overcome the issue
There was a problem hiding this comment.
path.join() used os separator that mean for Windows it would be \ so your path might look like this:
/ipfs\root\{CID}.
There was a problem hiding this comment.
Btw, memory is a mock engine for test.
|
*development branch, otherwise we won't be consistent |
# Conflicts: # packages/zkdb/package-lock.json # packages/zkdb/package.json # packages/zkdb/src/storage-engine/ipfs.ts # packages/zkdb/src/storage-engine/metadata.ts
Feature type
Feature description
Pull request checklist
Please check if your PR fulfills the following requirements: