Fix IPFS issue #24
Merged
Fix IPFS issue #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiro-hiro
reviewed
Aug 2, 2023
| }, | ||
| start: true, | ||
| addresses: { | ||
| listen: ['/ip4/127.0.0.1/tcp/0'], | ||
| listen: ['/ip4/0.0.0.0/tcp/0'], |
There was a problem hiding this comment.
Do listen on 0.0.0.0 is dangerous?
There was a problem hiding this comment.
As far as I know, it is necessary as we want our node to be accessible to the public network
There was a problem hiding this comment.
Public network can access our node via NAT, so i don't think listen on 0.0.0.0 is a good thing.
There was a problem hiding this comment.
Maybe I have some gaps in the computer network, but in this case 127.0.0.1 will be enough? Should not we specify the private network address?
chiro-hiro
reviewed
Aug 2, 2023
chiro-hiro
reviewed
Aug 2, 2023
chiro-hiro
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature type
Feature description
Pull request checklist
Please check if your PR fulfills the following requirements: