Fix failing fp16 evaluation #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcmalli
requested changes
Jul 8, 2024
quadra/tasks/anomaly.py
Outdated
| @@ -386,10 +386,11 @@ def test(self) -> None: | |||
| batch_labels = batch_item["label"] | |||
| image_labels.extend(batch_labels.tolist()) | |||
| image_paths.extend(batch_item["image_path"]) | |||
| batch_images = batch_images.to(self.device).to(self.deployment_model.model_dtype) | |||
There was a problem hiding this comment.
It should be possible to pass both the device and the dtype with single .to() call according to the documentation. https://pytorch.org/docs/2.1/generated/torch.Tensor.to.html#torch-tensor-to
rcmalli
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently for finetuning and anomaly the evaluation tasks don't work properly when the model is trained with fp16 precision. This pr fixes the wrong dtype used for inputs.
Type of Change
Checklist
Please confirm that the following tasks have been completed: