Skip to content

v2.8.0: adiosLog.h (MSVC) #3150

Closed
Closed
@ax3l

Description

Describe the bug
I am trying to deploy ADIOS 2.8.0 via conda-forge.
conda-forge/adios2-feedstock#44

It does not build with MSVC.

To Reproduce
Please see link.

Error:

CompressBZIP2.cpp
%SRC_DIR%\source\adios2/helper/adiosLog.h(24): error C2059: syntax error: 'constant'
%SRC_DIR%\source\adios2/helper/adiosLog.h(24): error C3805: 'constant': unexpected token, expected either '}' or a ','
%SRC_DIR%\source\adios2\operator\compress\CompressBZIP2.cpp(81): warning C4267: '+=': conversion from 'size_t' to 'unsigned int', possible loss of data

Expected behavior
Build.

My guess is that ERROR is also defined as a macro in a stdlib:
https://github.com/ornladios/ADIOS2/blob/v2.8.0/source/adios2/helper/adiosLog.h#L24

See:
https://stackoverflow.com/a/10191253/2719194

Desktop (please complete the following information):

  • OS/Platform: Windows (on CI via Azure Pipelines in conda-forge)
  • Build:
    • MSVC 19.16.27045.0

Additional context
Conda-Forge deployment (WIP): conda-forge/adios2-feedstock#44

CC file author @JasonRuonanWang
CC release manager @chuckatkins

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions