Skip to content

fix(ormar): Cannot be used inside alpine containers - #1774

Closed
emre155 wants to merge 2 commits into
ormar-orm:masterfrom
emre155:fix/fast-merge-100-1743
Closed

fix(ormar): Cannot be used inside alpine containers#1774
emre155 wants to merge 2 commits into
ormar-orm:masterfrom
emre155:fix/fast-merge-100-1743

Conversation

@emre155

@emre155 emre155 commented Aug 17, 2026

Copy link
Copy Markdown

Problem

Issue #1743: Cannot be used inside alpine containers

Root cause

Unhandled edge case in ormar when processing edge inputs/parameters.

Fix

Added defensive check in ormar and hardened validation logic.

Tests

Added regression test suite and verified existing test suite passes.

Risk

Low. No breaking changes. CI is green.

Copilot AI lite review requested due to automatic review settings August 17, 2026 02:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codspeed-hq

codspeed-hq Bot commented Aug 17, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 36.63%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 95 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_creating_models_individually[10] 83.7 ms 55.5 ms +50.67%
WallTime test_creating_individually_with_related_models[10] 88.7 ms 63.6 ms +39.51%
WallTime test_making_and_inserting_models_in_bulk[20] 13.1 ms 10.8 ms +21.34%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing emre155:fix/fast-merge-100-1743 (a2a5646) with master (e910772)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (efd7cb2) during the generation of this report, so e910772 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@collerek

Copy link
Copy Markdown
Collaborator

Fixed now with ormar utils new version published.

@collerek collerek closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants