Conversation
|
Ayooo, thanks a lot for the PR! Can you also look into why the CI is failing 👀 |
|
At least the non-docker part seems to be because the github actions runner's Ubuntu version no longer has the |
|
Yeah good point... But I set it up once and it was working. Don't we just need to find the correct package and install it to fix it? |
|
You're making a good point too. I'm not extremely familiar with the Ubuntu ecosystem, but from https://answers.launchpad.net/ubuntu/+source/kcov/+question/818841 it seems Ubuntu 24 is just lagging behind on repackaging from Debian. I'm not sure if Github allows changing the Ubuntu runner release to sth older? EDIT: yep, going back to 22.04 did the trick |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage ? 66.04%
=======================================
Files ? 4
Lines ? 162
Branches ? 0
=======================================
Hits ? 107
Misses ? 55
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ah, got it. It seems like it's fixed! I guess we just need to update the Dockerfile for Zig 0.14 I believe. |
This time there's surprisingly few changes needed to make linuxwave work, definitely unlike my own experience with porting my projects to 0.14 ...