fix(fixtures): evaluate the rc of git-cliff correctly #1104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the test fixtures for #1061.
Motivation and Context
#1061 changed the fixtures system to allow checking git-cliff's return code. This unintentionally broke all fixtures. The problem was caused by GitHub running all bash scripts with
set -e
by default, leading to any failing command failing the entire script. I circumvented this by appending the git-cliff command with|| true
, thereby breaking the subsequent checks.This PR fixes the problem by adding
set +e
prior to running git-cliff, thus allowing evaluation of its rc as intended.Additionally it fixes the fixture
test-require-conventional-skipped
. This fixture never worked right, but was deemed successful due to the bug.How Has This Been Tested?
Running fixtures locally and in GitHub actions.
Screenshots / Logs (if applicable)
Types of Changes
Checklist: