Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viu: ignore CARGO_TARGET_DIR in build() #2

Closed
wants to merge 1 commit into from
Closed

viu: ignore CARGO_TARGET_DIR in build() #2

wants to merge 1 commit into from

Conversation

Lutetium-Vanadium
Copy link

If CARGO_TARGET_DIR is set, the binary gets built to there, but the PKGBUILD expects it to be in target directory. So package() will fail with the following message:

==> Starting package()...
install: cannot stat 'target/release/viu': No such file or directory
==> ERROR: A failure occurred in package().

@Lutetium-Vanadium
viu: ignore CARGO_TARGET_DIR in build()
2c2ce2a 
If `CARGO_TARGET_DIR` is set, the binary gets built to there, but the `PKGBUILD` expects it to be in `target` directory. So `package()` will fail with the following message:
```
==> Starting package()...
install: cannot stat 'target/release/viu': No such file or directory
==> ERROR: A failure occurred in package().
```
@orhun
Copy link
Owner

orhun commented Dec 15, 2020

Hey,
It'd be more appropriate to have --target-dir=target I think. It's also mentioned in the Wiki.
I updated the package according to that.

@orhun orhun closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lutetium-Vanadium @orhun