Fixes the image loading

[Helle-Daryd]

It was just a case of requesting the correct permission for Android sdk level 33 and above.

This partially fixes, #278 but it file urls for other things are still limited and for Google's sake we would have to start doing remote syncing to private files, because Google diskikes the idea of people sharing files.

[amberin]

Thanks a bunch!

Are we sure that READ_EXTERNAL_FILES is not needed for importing notebooks, or anything else?

[amberin]

@Helle-Daryd ExternalLinksTest is failing on API 34, because a permission prompt appears. I opened a PR against your branch to fix that: Helle-Daryd#1

[Helle-Daryd]

Are we sure that READ_EXTERNAL_FILES is not needed for importing notebooks, or anything else?

According to READ_EXTERNAL_STORAGE (which is what EXTERNAL_FILES_ACCESS previously mapped to) it is literally a nop on Android sdk level 33 and up, hence dropping it as a permission as well. We use ActivityResultContract for importing files, etc. and MANAGE_EXTERNAL_STORAGE for repositories.

This also means that we need to still investigate the rest of the bug relating to file: urls, because those should still be launchable via intents, but may not currently be?

The other permission we use, MANAGE_EXTERNAL_STORAGE is part of some other bugs including issues with having the app up on Google Play, because Google dislikes the idea of files being visible and interchangeable between apps.

[amberin]

@Helle-Daryd Sigh, I forgot to add SDK_INT logic to the permission rule... I won't be at the computer for a while, but I'll fix it later if you haven't already.

[amberin]

@Helle-Daryd Helle-Daryd#2

[k4r4b3y]

When can we expect a new release? I just got bitten by #278 as well. The file links to image files using relative paths do not work. Orgzly Revived briefly shows a left-to-right-flowing loading bar above its UI, but apart from that no image gets displayed inline, nor am I being redirected to my android image viewer for viewing the file. I am on orgzly revived 1.8.24 from fdroid.

[amberin]

I just published 1.8.25 a few seconds ago. :) But it usually takes a few days before it's available via F-Droid.

@k4r4b3y It would be great if you could mark #278 as solved once you have confirmed that 1.8.25 solves the issue for you.

[k4r4b3y]

@k4r4b3y It would be great if you could mark #278 as solved once you have confirmed that 1.8.25 solves the issue for you.

Can I mark the issue thread that doesn't belong to me as "marked"?

But it usually takes a few days before it's available via F-Droid.

Got it. I will be on the lookout.

[amberin]

Can I mark the issue thread that doesn't belong to me as "marked"?

Ah, no, probably not... But please leave a comment if you can. :)

[k4r4b3y]

But please leave a comment if you can. :)

Understood.

---

While I have your attention, could you also comment on my other issue: #295

Is avif support something easy to bring in (like updating some imagemagick binaries or something -- sorry if I sound nonsensical) or if it would require some major work.