-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selecting multiple notebooks #288
Allow selecting multiple notebooks #288
Conversation
There are now some differences in the top "app bar" menu choices depending on how many notebooks are selected: - The "export" and "rename" choices are removed when multiple notebooks are selected. - When setting the repository link of multiple notebooks, no repository is pre-selected, even if all notebooks are currently linked to the same repository. The rationale is that I found no good way of showing existing links to multiple repos, so it seemed better to me to never make a pre-selection. - When deleting a single notebook, its repository URL is shown in the dialog prompting whether to delete the linked repository file. However, when deleting multiple notebooks, no repository URLs are shown. The rationale is that I found no intuitive way of presenting multiple URLs in the dialog along with their corresponding notebooks.
If the only reason for this is to be able to delete multiple notebooks, perhaps there is an easier way to do just that? |
@alensiljak Thanks for the input!
Do you mean because of the change in the menu choices? My understanding was that this menu is supposed to be context-dependant, and that its content changes all the time, depending on activity, what is selected, etc. For example, when no notebooks are selected, the menu choices are completely different compared to when one notebook is selected. Hiding two options when multiple books are selected doesn't seem very confusing to me? I'll add a few pictures showing what these changes look like, just to make sure we're on the same page. |
Oh and yes, what you can do after this change is to delete multiple books, but also set their repo links and force save/load. |
The original Orgzly issue was created by someone who wanted to force load/save multiple books at once. |
Sorry for the flip-flopping; I realized I had forgotten to add tests of force loading and -saving. |
Woaaaaaaah this great u best |
There are now some differences in the top "app bar" menu choices depending on how many notebooks are selected: