Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting multiple notebooks #288

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

amberin
Copy link
Member

@amberin amberin commented Jul 2, 2024

There are now some differences in the top "app bar" menu choices depending on how many notebooks are selected:

  • The "export" and "rename" choices are removed when multiple notebooks are selected.
  • When setting the repository link of multiple notebooks, no repository is pre-selected, even if all notebooks are currently linked to the same repository. The rationale is that I found no good way of showing existing links to multiple repos, so it seemed better to me to never make a pre-selection.
  • When deleting a single notebook, its repository URL is shown in the dialog prompting whether to delete the linked repository file. However, when deleting multiple notebooks, no repository URLs are shown. The rationale is that I found no intuitive way of presenting multiple URLs in the dialog along with their corresponding notebooks.

There are now some differences in the top "app bar" menu choices
depending on how many notebooks are selected:

- The "export" and "rename" choices are removed when multiple notebooks
  are selected.
- When setting the repository link of multiple notebooks, no repository
  is pre-selected, even if all notebooks are currently linked to the
  same repository. The rationale is that I found no good way of showing
  existing links to multiple repos, so it seemed better to me to never
  make a pre-selection.
- When deleting a single notebook, its repository URL is shown in the
  dialog prompting whether to delete the linked repository file.
  However, when deleting multiple notebooks, no repository URLs are
  shown. The rationale is that I found no intuitive way of presenting
  multiple URLs in the dialog along with their corresponding notebooks.
@amberin amberin marked this pull request as ready for review July 2, 2024 22:54
@amberin amberin linked an issue Jul 2, 2024 that may be closed by this pull request
@alensiljak
Copy link
Contributor

If the only reason for this is to be able to delete multiple notebooks, perhaps there is an easier way to do just that?
I.e. a screen with a list of notebooks which can be deleted individually or selected with a checkbox and deleted all together.
It seems that a multi-select will be pretty confusing in the existing context.

@amberin
Copy link
Member Author

amberin commented Jul 4, 2024

@alensiljak Thanks for the input!

It seems that a multi-select will be pretty confusing in the existing context.

Do you mean because of the change in the menu choices? My understanding was that this menu is supposed to be context-dependant, and that its content changes all the time, depending on activity, what is selected, etc. For example, when no notebooks are selected, the menu choices are completely different compared to when one notebook is selected. Hiding two options when multiple books are selected doesn't seem very confusing to me?

I'll add a few pictures showing what these changes look like, just to make sure we're on the same page.

@amberin
Copy link
Member Author

amberin commented Jul 4, 2024

Oh and yes, what you can do after this change is to delete multiple books, but also set their repo links and force save/load.

@amberin
Copy link
Member Author

amberin commented Jul 4, 2024

The original Orgzly issue was created by someone who wanted to force load/save multiple books at once.

alensiljak
alensiljak previously approved these changes Jul 4, 2024
@amberin amberin marked this pull request as draft July 4, 2024 16:42
@amberin
Copy link
Member Author

amberin commented Jul 4, 2024

Some explanatory screenshots:

Context menu choices with one notebook selected:
2024-07-04-18-39-31

Context menu choices with multiple notebooks selected (no "export" or "rename" options):
2024-07-04-18-39-51

Setting the link of one notebook (currently linked repo is pre-selected):
2024-07-04-18-41-12

Setting the link of multiple notebooks (no repo is pre-selected):
2024-07-04-18-41-30

Deleting one synced notebook (synced-to-URL is shown):
2024-07-04-18-48-47

Deleting multiple synced notebooks (no URLs are shown):
2024-07-04-18-49-02

@amberin amberin marked this pull request as ready for review July 4, 2024 17:23
@amberin
Copy link
Member Author

amberin commented Jul 4, 2024

Sorry for the flip-flopping; I realized I had forgotten to add tests of force loading and -saving.

@Wjxfi
Copy link

Wjxfi commented Jul 17, 2024

Woaaaaaaah this great u best

@amberin amberin requested a review from alensiljak July 23, 2024 21:06
@amberin amberin merged commit e1e4df3 into orgzly-revived:master Jul 25, 2024
4 checks passed
@amberin amberin deleted the select-multiple-notebooks-pr branch July 25, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow selecting multiple notebooks
3 participants