Support the .orgzlyignore file in all repo types #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amberin
requested review from
alensiljak,
stefan2904,
colonelpanic8,
cbkerr and
chvp
|
I have added documentation in this branch: https://github.com/amberin/orgzly-revived-documentation/blob/pr-282/miscellaneous.org#ignoring-files-in-a-repository PR in the documentation repo: https://github.com/orgzly-revived/documentation/pull/3/files |
…ore rules The class extends the JGit class IgnoreNode, which can do most of the work for us. The SyncRepo interface needed a new method to allow reading an arbitrary file from the repository, since the .orgzlyignore file is not an ORG file.
I also speeded up the Git file tree walk. (We were performing similar checks two times -- first in the TreeFilter.include() method override, and then later in the actual processing of interesting nodes. I have concluded that we can filter out all uninteresting nodes in one place.)
|
Rebased on master. |
|
Since there is no feedback, I'll merge this and publish a new beta release, and hopefully we can get some real-world testing done with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #224 for background.
This needs to be described in the user documentation. So I suppose we need a domain for hosting the user documentation...
Edit: I just bought orgzlyrevived.com.