Dropbox repos: Use the new "refresh token" OAuth flow #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated here: https://www.dropboxforum.com/t5/Dropbox-API-Support-Feedback/Java-SDK-issues-with-short-lived-token/m-p/508693/highlight/true#M25109. - Store the DbxCredential object in JSON form in app preferences. - Store requestConfig as a property, since it is now needed in many places. - Write a mock credential to preferences when preparing for Dropbox-related tests. - Remove unused updating of Dropbox token in SyncTest. - Clean up some unused imports. All tests in the "repos" directory are now passing.
amberin
requested review from
alensiljak,
stefan2904,
colonelpanic8,
maikol-solis,
cbkerr and
chvp
alensiljak
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated here: https://www.dropboxforum.com/t5/Dropbox-API-Support-Feedback/Java-SDK-issues-with-short-lived-token/m-p/508693/highlight/true#M25109.
All tests in the "repos" directory (and all other tests) are now passing. Before this change, the access token used by Orgzly would expire within a few hours, since only short-lived tokens are now handed out when using the old OAuth flow.