Skip to content

Use a single datetime for all filenames across a snapshot #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stephane-klein
Copy link
Contributor

Proposed implementation of issue #146.

@stephane-klein
Copy link
Contributor Author

@orgrim What do you think?

@stephane-klein stephane-klein force-pushed the issue-146-proposal-to-define-a-datetime-only-between-all-files-in-a-snapshot branch from 95eb903 to bc5fa17 Compare April 19, 2025 16:38
@stephane-klein
Copy link
Contributor Author

Further to this comment, this Pull Request has been updated with :

  • cli parameter --uniform-snapshot-timestamp
  • configuration parameter uniform_snapshot_timestamp

@orgrim What do you think?

@stephane-klein stephane-klein force-pushed the issue-146-proposal-to-define-a-datetime-only-between-all-files-in-a-snapshot branch from bc5fa17 to 0103662 Compare April 24, 2025 15:23
@stephane-klein
Copy link
Contributor Author

I've replaced --uniform-snapshot-timestamp with --uniform-timestamp.

@orgrim need review

@stephane-klein stephane-klein force-pushed the issue-146-proposal-to-define-a-datetime-only-between-all-files-in-a-snapshot branch from 0103662 to 9161089 Compare April 24, 2025 15:27
@stephane-klein stephane-klein requested a review from orgrim April 25, 2025 09:14
@stephane-klein stephane-klein force-pushed the issue-146-proposal-to-define-a-datetime-only-between-all-files-in-a-snapshot branch from 9161089 to bbb1871 Compare June 11, 2025 21:08
This option apply a single consistent timestamp to all filenames generated by pg_back instead of using individual file creation times.
@stephane-klein stephane-klein force-pushed the issue-146-proposal-to-define-a-datetime-only-between-all-files-in-a-snapshot branch from bbb1871 to c1dcb89 Compare June 11, 2025 21:35
@stephane-klein
Copy link
Contributor Author

I think I have taken all the correction requests into account.

I have rebased this Pull Request.

@orgrim New review request.

@stephane-klein
Copy link
Contributor Author

stephane-klein commented Jun 19, 2025

@orgrim bump

@orgrim
Copy link
Owner

orgrim commented Jun 19, 2025

@stephane-klein I'm quite busy, I'll see what I can do this week-end

@Its-Alex
Copy link

Hi! 👋 Just wanted to say I'm very interested in this feature — it would be really helpful for my use case. @orgrim If you or someone has time to review the MR soon, that would be amazing. Thanks in advance!

@orgrim orgrim merged commit 5375ec2 into orgrim:master Jun 26, 2025
9 checks passed
@stephane-klein
Copy link
Contributor Author

@orgrim thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants