This repository has been archived by the owner on Nov 25, 2020. It is now read-only.
Limit the size of a single datagram and send multiple datagrams if you h... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u have more metrics than can fit into a single UDP packet
|
@matthewbogner I am not sure if I have the same issue as you described. I can only see some of my metrics sending to StatsD from wireshark. I don't see any error message. Majority of my metrics seems silently dropped. To me, version 2.3 is not usable. |
|
This is a very serious bug. I agree with previous commenter that it makes 2.3.0 practically unusable. |
|
#15 should fix this. Just need a test. Feel free to contribute to it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ave more metrics than can fit into a single UDP packet. Without limiting the size of the datagram, it's possible your packet will fail to be sent.