fix: display http(s) reflinks too #327
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider a node with: :ROAM_REFS: http://www.example.net And another node referencing the page with a (plain) link: Lorem ipsum http://www.example.net ... With the point inside the first node, the roam buffer lists the other node under the "Reflinks" section as expected, but the roam UI does not give any clue about the relation between these two. This commit ensures that the http(s) links that have nodes with associated refs are converted to id based links of type ref, so that the UI can handle them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a node with:
And another node referencing the page with a (plain) link:
With the point inside the first node, the roam buffer lists the other node under the "Reflinks" section as expected, but the roam UI does not give any clue about the relation between these two.
This commit ensures that the http(s) links that have nodes with associated refs are converted to id based links of type ref, so that the UI can handle them.