Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move to dispatch conditions / NIOLock instead of raw pthread mutex/conditions #39

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Oct 28, 2022

Fixes #21

Basically borrowed NIOLock for the time being until we have some other native swift concurrency primitive for synchronisation, using dispatch semaphores instead of pthread ones.

@hassila hassila requested a review from mr-swifter October 28, 2022 07:58
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #39 (cab6379) into main (b7e7a19) will decrease coverage by 0.24%.
The diff coverage is 88.57%.

❗ Current head cab6379 differs from pull request most recent head d21c581. Consider uploading reports for the commit d21c581 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   83.59%   83.36%   -0.24%     
==========================================
  Files          19       20       +1     
  Lines        2200     2241      +41     
==========================================
+ Hits         1839     1868      +29     
- Misses        361      373      +12     
Impacted Files Coverage Δ
...s/BenchmarkSupport/BenchmarkRunner+ReadWrite.swift 57.14% <ø> (ø)
Sources/BenchmarkSupport/NIOLock.swift 74.19% <74.19%> (ø)
Sources/Benchmark/Benchmark.swift 82.24% <100.00%> (-0.54%) ⬇️
...ort/MallocStats/MallocStatsProducer+jemalloc.swift 76.14% <100.00%> (ø)
...stemStats/OperatingSystemStatsProducer+Linux.swift 95.56% <100.00%> (+1.23%) ⬆️
Impacted Files Coverage Δ
...s/BenchmarkSupport/BenchmarkRunner+ReadWrite.swift 57.14% <ø> (ø)
Sources/BenchmarkSupport/NIOLock.swift 74.19% <74.19%> (ø)
Sources/Benchmark/Benchmark.swift 82.24% <100.00%> (-0.54%) ⬇️
...ort/MallocStats/MallocStatsProducer+jemalloc.swift 76.14% <100.00%> (ø)
...stemStats/OperatingSystemStatsProducer+Linux.swift 95.56% <100.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e7a19...d21c581. Read the comment docs.

@hassila hassila merged commit 13d1a5f into main Oct 28, 2022
@hassila hassila deleted the remove-raw-pthread-conditions branch October 28, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing pthread semaphores and move to groue/Semaphore
2 participants