fix(patch): Rename 'Shared' target to 'BenchmarkShared' #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 69.48% 69.48%
=======================================
Files 33 33
Lines 3938 3938
=======================================
Hits 2736 2736
Misses 1202 1202
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
"This PR also adds '.git' to repo URLs since that makes sure we avoid a Xcode-x-SwiftPM bug." Could you explain what bug more specifically? |
hassila
approved these changes
May 3, 2025
|
@hassila found the related issue: swift-server/async-http-client#770 | my comment Edit: also after this happened, I saw Cory doing PRs in their other repos to work around this bug and also unify the URLs with .git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'Shared' is too much of a popular word for a target name. Apps that already have a target named 'Shared' won't be able to use that target in combination with this package.
This PR unblocks us to update our Package-Benchmark without having to rename our 'Shared' target.
This PR also adds '.git' to repo URLs since that makes sure we avoid a Xcode-x-SwiftPM bug. After we reported this a bunch of months ago, NIO team have also been updating their packages with this. Can't find a link to that discussion but you can at least see that packages like SwiftNIO are using '.git' (link).
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Minimal checklist:
DocCcode-level documentation for any public interfaces exported by the package