Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using LOG_DEPRECATIONS_WHILE_TESTING environment variable #171

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

crynobone
Copy link
Member

This matches laravel/framework#49457 feature except Testbench still logs deprecation by default and you can disable it by adding LOG_DEPRECATIONS_WHILE_TESTING=(false)

This matches laravel/framework#49457 feature except Testbench still logs
deprecation by default and you can disable it by adding
`LOG_DEPRECATIONS_WHILE_TESTING=(false)`

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone added enhancement New feature or request poc labels Dec 21, 2023
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review December 21, 2023 03:13
@coveralls
Copy link

Coverage Status

coverage: 91.36% (+0.007%) from 91.353%
when pulling 3dc2b2b on deprecation-env
into 033e085 on 8.x.

@crynobone crynobone merged commit 17788ba into 8.x Dec 21, 2023
@crynobone crynobone deleted the deprecation-env branch December 21, 2023 15:39
crynobone added a commit that referenced this pull request Dec 21, 2023
* Allow using `LOG_DEPRECATIONS_WHILE_TESTING` environment variable

This matches laravel/framework#49457 feature except Testbench still logs
deprecation by default and you can disable it by adding
`LOG_DEPRECATIONS_WHILE_TESTING=(false)`

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

* wip

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

* wip

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

---------

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request poc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants