v0.1.12#1
Merged
Merged
Conversation
…ish` Before this commit, there is no kind of mutual exclusion in between calling `p.condition` and `manager.on_start`, so two processes can "request" more resources than the ones really available on the system because of this. This situation leaded to some "tricks" such as performing some actions at the condition call, when they should have been done at the `on_start` call. Right now, everything should be working in a known and expected way for all the existing plugins and the new ones
If the condition wasn't satisfied, the action was run (which shouldn't happen). It was because of the refactoring done, as a `return` statement was necessary if the condition wasn't evaluated to `True`
…ators
We have detected some errors at Orcha's petition handler whenever an
`EmptyPetition` was enqueued:
```
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/orcha/lib/manager.py", line 287, in shutdown
self.manager.shutdown()
File "/usr/lib/python3/dist-packages/orcha/lib/processor.py", line 314, in _process
self._internalq.put(p)
File "/usr/lib/python3.9/queue.py", line 150, in put
self._put(item)
File "/usr/lib/python3.9/queue.py", line 236, in _put
heappush(self.queue, item)
TypeError: '<' not supported between instances of 'EmptyPetition' and 'VagrantPetition'
```
That error was causing some troubles when we request the orchestrator to finish
In addition, we implemented new features for handling SystemD watchdog if we
are running as a service: every 5 seconds, a `WATCHDOG` is sent to notify about
our behavior. If an error occurs in a critical section thread, we notify about
such error and request a service restart, for safety reasons.
There was an issue with previous commit which caused:
```
Traceback (most recent call last):
File "${DIST_PACKAGES}/orcha/__init__.py", line 25, in <module>
from .interfaces import *
File "${DIST_PACKAGES}/orcha/interfaces/__init__.py", line 24, in <module>
from .petition import (
File "${DIST_PACKAGES}/orcha/interfaces/petition.py", line 208, in <module>
class EmptyPetition(Petition):
File "/usr/lib/python3.7/dataclasses.py", line 983, in wrap
return _process_class(cls, init, repr, eq, order, unsafe_hash, frozen)
File "/usr/lib/python3.7/dataclasses.py", line 868, in _process_class
raise TypeError('cannot inherit frozen dataclass from a '
TypeError: cannot inherit frozen dataclass from a non-frozen one
```
So then, child classes were updated so they are mutable
… clients The internal digest key is not working properly on Python versions lower or equal to 3.7, and it requires a manual fix. Such fix was introduced on server side but never on client side, which now is
In addition, the `manager` itself has been updated for handling authentication error that may be caused if the key is missing (showing a helpful message in such situation). As there is no exception throwing in that situation, the `connect` method was updated so it returns a boolean indicating whether if the client has been connected or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.